Skip to content

[donet]: clean code and line number for info #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

[donet]: clean code and line number for info #2214

merged 2 commits into from
Mar 11, 2025

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Mar 11, 2025 •
edited by qodo-merge-pro bot
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Removed assert from code snippet for donet binding and format comments

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement, Documentation

Description

  • Improved code formatting in InformationTest.cs for better readability.

  • Updated documentation references to match revised line numbers in InformationTest.cs.

  • Added a new VSCode configuration file for Java build settings.

Changes walkthrough 📝

Relevant files
Configuration changes
settings.json
Add VSCode Java build configuration                                           

.vscode/settings.json

  • Added a new configuration file for VSCode.
  • Configured Java build settings to "interactive".
    		• +3/-0     
    Enhancement
    InformationTest.cs
    Improve code formatting in InformationTest.cs                       

    examples/dotnet/SeleniumDocs/Elements/InformationTest.cs

  • Reformatted comments for consistency and readability.
  • Adjusted spacing and alignment in code snippets.
  • No functional changes to the code logic.
    		• +13/-13 
    Documentation
    information.en.md
    Update English documentation for C# code changes                 

    website_and_docs/content/documentation/webdriver/elements/information.en.md

  • Updated line number references for C# code snippets.
  • Adjusted documentation to align with reformatted InformationTest.cs.
    		• +8/-8     
    information.ja.md
    Update Japanese documentation for C# code changes               

    website_and_docs/content/documentation/webdriver/elements/information.ja.md

  • Updated line number references for C# code snippets.
  • Adjusted Japanese documentation to align with reformatted
    InformationTest.cs.
    		• +8/-8     
    information.pt-br.md
    Update Portuguese documentation for C# code changes           

    website_and_docs/content/documentation/webdriver/elements/information.pt-br.md

  • Updated line number references for C# code snippets.
  • Adjusted Portuguese documentation to align with reformatted
    InformationTest.cs.
    		• +8/-8     
    information.zh-cn.md
    Update Chinese documentation for C# code changes                 

    website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md

  • Updated line number references for C# code snippets.
  • Adjusted Chinese documentation to align with reformatted
    InformationTest.cs.
    		• +8/-8     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @netlify Netlify
    Copy link

    netlify bot commented Mar 11, 2025 •
    edited
    Loading

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 490262c

    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Mar 11, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    harsha509
    harsha509 approved these changes Mar 11, 2025
    View reviewed changes
    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    Thank you @Delta456 !

    @harsha509
    Copy link
    Member

    Test failures are not related to the changes in the PR!

    @harsha509 harsha509 merged commit 067b882 into SeleniumHQ:trunk Mar 11, 2025
    5 of 9 checks passed
    @Delta456 Delta456 deleted the info_csharp branch March 11, 2025 14:01
    selenium-ci added a commit that referenced this pull request Mar 11, 2025
    @selenium-ci
    [donet]: clean code and line number for info (#2214)[deploy site]
    ddc8999 
    * [donet]: clean code and line number for info

* oops 067b882
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @harsha509 harsha509 harsha509 approved these changes

    Assignees
    No one assigned
    Labels
    Review effort 1/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @Delta456 @harsha509